clients/lsp-trunk.el - prevent error when using lsp on non-file buffer #4885
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protect against error when (file-name-directory filename) is nil which occurs on non-file buffer. We were hitting this when using lsp-mode with the p4.el package which when diff'ing pulls files from Perforce into non-file buffers and then activates a major mode that runs lsp. This ends up calling lsp-trunk-check-for-init.
jcs090218
reviewed
Sep 30, 2025
Protect against error when (file-name-directory filename) is nil which occurs on non-file buffer. We were hitting this when using lsp-mode with the p4.el package which when diff'ing pulls files from Perforce into non-file buffers and then activates a major mode that runs lsp. This ends up calling lsp-trunk-check-for-init.
Co-authored-by: Sebastiaan Speck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protect against error when (file-name-directory filename) is nil which occurs on non-file buffer. We were hitting this when using lsp-mode with the p4.el package which when diff'ing pulls files from Perforce into non-file buffers and then activates a major mode that runs lsp. This ends up calling lsp-trunk-check-for-init.